Skip to content

Conversation

@DamienGilliard
Copy link
Collaborator

@DamienGilliard DamienGilliard commented Sep 19, 2024

This PR concerns "safety fixes": runtime errors, default values and so on, for the components.

Components modified:

  • CAD segentator:
    Capture d'écran 2024-09-19 202830

Additionally, because of the way the componentizer changes the code, errors appear due to lack of import Rhino and import System:

initial code:
image

after:
Capture d'écran 2024-09-19 211809

Thus the code is changed in all component to avoid this error, by adding the two imports

No additional testing is needed, but documentation is modified to track default values

@DamienGilliard DamienGilliard marked this pull request as draft September 19, 2024 18:38
@DamienGilliard DamienGilliard self-assigned this Sep 19, 2024
@DamienGilliard DamienGilliard added documentation Improvements or additions to documentation grasshopper labels Sep 19, 2024
@DamienGilliard DamienGilliard linked an issue Sep 19, 2024 that may be closed by this pull request
@9and3 9and3 marked this pull request as ready for review September 20, 2024 16:04
@9and3 9and3 merged commit ec0c5cf into main Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation grasshopper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CADSegmentator should have default error without trow an error when dropped to the canvas Renaming: o_clusters should be renamed o_clouds

3 participants